Skip to content

Match.group can return None #3982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Match.group can return None #3982

wants to merge 1 commit into from

Conversation

mr-c
Copy link
Contributor

@mr-c mr-c commented May 13, 2020

No description provided.

@hauntsaninja
Copy link
Collaborator

Discussion on #3902 aside, we should use overloads and TypeVars for default, since if you provide default="a string" the return types are no longer optional.

@JelleZijlstra JelleZijlstra mentioned this pull request May 30, 2020
Closed
@srittau
Copy link
Collaborator

srittau commented Sep 17, 2020

Closing this here per the discussion in #3902. While we can probably make a few improvements using overloads, just adding Optional to the return types would break lots of existing, correct code.

@srittau srittau closed this Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mr-c @hauntsaninja @srittau