pathlib.Path.open: bring on the overloads #4407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hauntsaninja
force-pushed
the
path
branch
2 times, most recently
from
16f9cdd to
afcf7b8
Compare
|
Why are there 4 different specific binary modes ( |
|
@Akuli text mode returns the same concrete type regardless of the precise mode, while binary mode returns different types. |
third_party/2/pathlib2.pyi
Outdated
| ) -> BinaryIO: ... | ||
| # Fallback if mode is not specified |
There was a problem hiding this comment.
I'm not sure this is right in Python 2; our stub for builtins currently always return BinaryIO from Python 2's open.
There was a problem hiding this comment.
Good point, check_consistent has just conditioned me to copy-paste. One day we'll be free.
|
gentle bump! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.