Add more constants and attributes to posix #4552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The constants were found by running dir(posix) on a Debian 10.5 (x86_64) system. Also mark module as incomplete. Partly addresses python#616.
hauntsaninja
approved these changes
Sep 17, 2020
There was a problem hiding this comment.
Thanks! I'm not sure we should mark with __getattr__... it looks to me like the stub is mostly complete, so a) this would cause false negatives on typos, b) false positives are rare and to the extent that they lead to contributions are good. The linked issue predates many sizable contributions to this stub.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constants were found by running dir(posix) on a Debian 10.5 (x86_64)
system.
Also mark module as incomplete.
Partly addresses #616.