More consistency checks for dependencies #4990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JukkaL
reviewed
Feb 1, 2021
| def _strip_dep_version(dependency): | ||
| dep_version_pos = len(dependency) | ||
| for pos, c in enumerate(dependency): | ||
| if c in "=<>": |
There was a problem hiding this comment.
What if there is a semicolon? Example from mypy test-requirements.txt:
flake8-bugbear; python_version >= '3.5'
We check for spaces, but somebody might write something like this:
types-foo;python_version>='3.5'
Maybe use a regexp to validate the version string so that we don't check for bad things but ensure that only expected things exist?
There was a problem hiding this comment.
Again, there should not be semicolons, requires is already a list.
There was a problem hiding this comment.
Sorry, I didn't notice what is in the second part, I think we may not support this initially.
| return stripped, "", "" | ||
| number_pos = 0 | ||
| for pos, c in enumerate(rest): | ||
| if c not in "=<>": |
srittau
approved these changes
Feb 1, 2021
tests/check_consistent.py
Outdated
| for space in " \t\n": | ||
| assert space not in dep, f"For consistency dependency should not have whitespace: {dep}" | ||
| stripped, relation, dep_version = _strip_dep_version(dep) | ||
| assert stripped in known_distributions, f"Only known dependencies are supported, got {stripped}" |
There was a problem hiding this comment.
Nit: Maybe "Only dependencies from typeshed are supported, got {stripped}"
|
Opened #4995 as a follow-up from offline discussions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4988