Run pylance tests in CI #5051
Run pylance tests in CI #5051
Conversation
|
|
||
|
|
||
| _WELL_KNOWN_FILE = Path("tests", "pyright_test.py") | ||
| _PYRIGHT_COMMAND = ["npx", "-p", "[email protected]", "pyright"] |
There was a problem hiding this comment.
Should this be unpinned, if mypy is getting run at master (based on the requirements file, anyway)?
There was a problem hiding this comment.
Ah, I see #5048 says this is probably just a starter PR, ignore me :)
There was a problem hiding this comment.
I think we'd prefer a pinned version, so our CI doesn't start failing with no action. mypy is currently run from master because of transitional state around the recent directory reorganization.
There was a problem hiding this comment.
Pinning mypy was discussed in #4332. I am still in favor of it (and we should also pin pytest while we are at it). As Jelle pointed out, using master has the disadvantage that build can fail for reasons unrelated to a PR.
| @@ -85,6 +85,14 @@ jobs: | |||
| - uses: actions/setup-python@v2 | |||
| - run: ./tests/mypy_test_suite.py | |||
|
|
|||
| pyright: | |||
| name: Run the pyright test suite | |||
There was a problem hiding this comment.
| name: Run the pyright test suite | |
| name: Run pyright against the stubs |
No description provided.