Remove tornado stubs #5220
Closed
Remove tornado stubs #5220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tornado has inline stubs.
|
Cc @JukkaL The stubs in typeshed are Python 2 only, though! |
These stubs are only used for Python 2 (metadata includes The inline annotations won't work on Python 2, so the stubs are still valuable for users using Python 2, and removing the stubs would make things worse for them, I think. |
|
Ah, my mistake, I had missed that metadata. Sorry for the noise! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tornado ships with quite nice inline annotations, and the stubs in this repository have fallen behind.
It seems they were already removed in #4321, restored for python 2-only in #4412, and now seem to have snuck back into general python2/3 usage. I think keeping these around creates more problems than they solve