[WIP] Add docutils/nodes stubs #5237
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieleades
force-pushed
the
docutils/nodes
branch
from
c771803 to
ca7d23f
Compare
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
1 similar comment
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
|
@Akuli, @srittau
note that this is still very much a work in progress. i've only manually added types to a small subset of the total file. i may not attempt to do the whole file in this one pull request (it's a big'un) edit: I see from the contributing guide, that the dummy |
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
|
Yup, it's preferable to remove autogenerated You can check consistency with source using: (CI jobs only do this automagically for stdlib, currently) |
|
Thank you for this! I haven't looked at it in depth, but I have a minor style nit: Defaults ( |
when are defaults required? |
|
Defaults are only useful for function and method arguments. |
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
i think i'm doing this wrong. am i using this correctly? can i limit the consistency check to only update: figured it out. using the wrong interpreter mypy.stubtest output |
|
so i'm a little surprised to discover that adding is that expected? |
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
|
For stubtest? Yeah, that's expected. stubtest is meant to help you complete and check stubs and if something is not-dynamic enough that stubtest can find it, it really should be in the stubs. If you want stubtest to shut up about things you haven't added yet and just check the things that you have, run with |
I concur. a quick diff shows a lot of differences
@tk0miya, if you have the time i'd really appreciate a review edit: on second thoughts, it might be better to abandon this pull request, and do a wholesale merge of https://github.com/tk0miya/docutils-stubs into typeshed. It's far more complete that what i've done here. I'll be happy to review that pull request |
|
@tk0miya how do you feel about opening a pull request to merge your work in docutils stubs? |
|
Any updates here? |
|
Going to close this as stale for now to keep the list of open PRs manageable. If you're still interested in seeing this through, feel free to reopen or open a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.