Skip to content

Fixed: Argument for Werkzeug's Headers.pop method. #5335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 5, 2021
Merged

Fixed: Argument for Werkzeug's Headers.pop method. #5335

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6e0736b
Fixed: Argument for Werkzeug's Headers.pop method
01-vyom May 4, 2021
1ed1bcd
Changed: Overloaded Headers.pop function to support different argumen…
01-vyom May 4, 2021
ec4d0b3
Changed: Overload Headers.pop method to support correct cases.
01-vyom May 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions stubs/Werkzeug/werkzeug/datastructures.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,14 @@ class Headers(object):
def extend(self, iterable): ...
def __delitem__(self, key: Any) -> None: ...
def remove(self, key): ...
def pop(self, **kwargs): ...
@overload
def pop(self, key: Optional[int] = ...) -> str: ... # default is ignored, using it is an error
@overload
def pop(self, key: str) -> str: ...
@overload
def pop(self, key: str, default: str) -> str: ...
@overload
def pop(self, key: str, default: None) -> Optional[str]: ...
def popitem(self): ...
def __contains__(self, key): ...
has_key: Any
Expand All @@ -217,7 +224,14 @@ class ImmutableHeadersMixin:
add_header: Any
def extend(self, iterable): ...
def insert(self, pos, value): ...
def pop(self, **kwargs): ...
@overload
def pop(self, key: Optional[int] = ...) -> str: ... # default is ignored, using it is an error
@overload
def pop(self, key: str) -> str: ...
@overload
def pop(self, key: str, default: str) -> str: ...
@overload
def pop(self, key: str, default: None) -> Optional[str]: ...
def popitem(self): ...
def setdefault(self, key, default): ...

Expand Down