Refine stubs for numbers.pyi #543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refines numbers.pyi. More specifically, it... - Adds in explicit type annotations where it's obvious how to do so (leaving more non-obvious type signatures alone). - Adds in missing '@AbstractMethod' decorators - Combines together the Python 2 and Python 3 versions of numbers.pyi.
This commit removes the old `stdlib/2.7/numbers.pyi` file and moves the previously-committed `stdlib/3/numbers.pyi` to the shared `2and3` directory.
Since the stubs are no longer identical to what stubgen creates, the comment should also probably be changed.
|
Thanks! I'll just merge this and deal with the fall-out later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refines the stubs for
numbers.pyi. More specifically, it...__float__method should always return a float)@abstractmethoddecoratorsnumbers.pyi-- I deleted the versions ofnumbersinstdlib/2.7andstdlib/3and created a combined version instdlib/2and3I deliberately didn't attempt to add or change the type signatures for functions like
__add__since it looked like that would open up a huge can of worms.