Skip to content

Use concrete type in sys.excepthook() #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2016
Merged

Conversation

smessmer
Copy link
Contributor

This is necessary, because exception formatting functions like traceback.format_exception() expect to get Type[BaseException], but sys.excepthook only provided type

This is necessary, because exception formatting functions like `traceback.format_exception()` expect to get `Type[BaseException]`, but sys.excepthook only provided `type`
@gvanrossum gvanrossum merged commit 96ba625 into python:master Sep 14, 2016
@gvanrossum
Copy link
Member

Thanks for the fix! There are probably more like this...

--Guido (mobile)

On Sep 14, 2016 5:20 AM, "Sebastian Meßmer" [email protected]
wrote:

This is necessary, because exception formatting functions like
traceback.format_exception() expect to get Type[BaseException], but

sys.excepthook only provided type

You can view, comment on, or merge this pull request online at:

#547
Commit Summary

  • Use concrete type in sys.excepthook()

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#547, or mute the thread
https://github.com/notifications/unsubscribe-auth/ACwrMl4VfUk5UhB1VyJr-6zODyqtyO4Eks5qp-aVgaJpZM4J8tWF
.

@smessmer smessmer deleted the patch-1 branch September 14, 2016 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants