Skip to content

Improved OpenSSL stubs #5645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 36 commits into from
Jun 16, 2021
Merged

Improved OpenSSL stubs #5645

merged 36 commits into from
Jun 16, 2021

Conversation

jolaf
Copy link
Contributor

@jolaf jolaf commented Jun 15, 2021 •
edited
Loading

Fixes #2052.

  • Added missing stubs for OpenSSL.SSL
  • Added some missing annotations to OpenSSL.crypto
  • Improved imports structure
  • Fixed _StrLike and _BytesLike annotations
  • Fixed passphrase callback annotations
  • Reordered classes and methods according to official documentation

jolaf and others added 30 commits October 7, 2019 17:41
@jolaf
Merge pull request #1 from python/master
0a41f92 
Merge from master
@jolaf
Merge pull request #2 from python/master
6147b57 
Merge from master
Merge remote-tracking branch 'upstream/master'
24ccd88
Merge remote-tracking branch 'upstream/master'
8a67575
Merge remote-tracking branch 'upstream/master'
7208709
Merge remote-tracking branch 'upstream/master'
fb441f4
Merge remote-tracking branch 'upstream/master'
6842d78
Stubs for pyaudio added
84897db
Fixed for new format
f7a40e8
Trying to backport for Python 3.6
3204ff5
Fixed according to build checks
e2b2552
Fixed according to build checks
c5d7d62
Fixed according to build checks
1524136
Avoiding Literal as causing too much trouble in actual use
42c500f
Trying Python 2 compatibility
3be6149
Fixed error in annotation
6f8d928
Empty commit to trigger timed out build check
03e4dca
Revert "Empty commit to trigger timed out build check"
605c18d 
This reverts commit 03e4dca.
Added _ before auxiliary type names
e4a364d
Provided the actual version number
d2a5e1c
Fixed AssertionError: Unsupported Python version 0.2.11
1821870
Merge remote-tracking branch 'upstream/master'
8fa12cd
Added missing OpenSSL stubs
80d773e
Improved imports
0419f58
Fixed _StrLike and _BytesLike annotations, as well as passphrase call…
b354973 
…back annotations
More annotation fixes
fe4aa2a
Reordering classes according to official documentation per https://ww…
5e6fd23 
…w.pyopenssl.org/en/stable/api/crypto.html
Added missing OpenSSL stubs
4b9a50d
Reordering class fields according to official documentation per https…
1ab37de 
…://www.pyopenssl.org/en/stable/api/crypto.htmlAdded missing OpenSSL stubs
Formatting fixes
4798d01
@srittau srittau mentioned this pull request Jun 16, 2021
Closed
srittau
srittau requested changes Jun 16, 2021
View reviewed changes
Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Could you also update the version in METADATA.toml? I think we should also remove python3 = false as this package supports Python 3 and the stubs seem fine. A few more remarks below.

srittau
srittau requested changes Jun 16, 2021
View reviewed changes
Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I noticed one replace error below. Also, please replace Optional[X] with X | None (outside type aliases) and update the library version. Apart from that the changes look good.

@jolaf jolaf requested a review from srittau June 16, 2021 14:37
@srittau srittau merged commit ff75793 into python:master Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srittau srittau srittau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add stubs for OpenSSL.SSL
2 participants
@jolaf @srittau