-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Fix to pyOpenSSL stubs to pass stubtest #5657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
0a41f92
Merge pull request #1 from python/master
jolaf 6147b57
Merge pull request #2 from python/master
jolaf 24ccd88
Merge remote-tracking branch 'upstream/master'
8a67575
Merge remote-tracking branch 'upstream/master'
7208709
Merge remote-tracking branch 'upstream/master'
fb441f4
Merge remote-tracking branch 'upstream/master'
6842d78
Merge remote-tracking branch 'upstream/master'
84897db
Stubs for pyaudio added
f7a40e8
Fixed for new format
3204ff5
Trying to backport for Python 3.6
e2b2552
Fixed according to build checks
c5d7d62
Fixed according to build checks
1524136
Fixed according to build checks
42c500f
Avoiding Literal as causing too much trouble in actual use
3be6149
Trying Python 2 compatibility
6f8d928
Fixed error in annotation
03e4dca
Empty commit to trigger timed out build check
605c18d
Revert "Empty commit to trigger timed out build check"
e4a364d
Added _ before auxiliary type names
d2a5e1c
Provided the actual version number
1821870
Fixed AssertionError: Unsupported Python version 0.2.11
8fa12cd
Merge remote-tracking branch 'upstream/master'
80d773e
Added missing OpenSSL stubs
0419f58
Improved imports
b354973
Fixed _StrLike and _BytesLike annotations, as well as passphrase call…
fe4aa2a
More annotation fixes
5e6fd23
Reordering classes according to official documentation per https://ww…
4b9a50d
Added missing OpenSSL stubs
1ab37de
Reordering class fields according to official documentation per https…
4798d01
Formatting fixes
ab5ae9f
Formatting fixes
037ccc2
Updated per review by @srittau
d8d2531
More fixes
714d9d2
Replaced Optional with | syntax
ec63bbf
Reverted version for now
f0b16bc
Temporarily disable stubtest
srittau c46a01c
Merge remote-tracking branch 'upstream/master'
3f280c3
Merge remote-tracking branch 'upstream/master'
552aac4
Merge branch 'master' into openssl
0364062
Trying to enable all tests
4ea40bd
Fixed stubs according to stubtest
026bb5a
Fixed stubs according to stubtest
81f044a
Fixed stubs according to stubtest
79603ef
Excluded stubtest for OpenSSL.crypto, as the respective fix to mypy i…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1 @@ | ||
OpenSSL.SSL.Connection.__init__ | ||
OpenSSL.SSL.Context.load_verify_locations | ||
OpenSSL.SSL.Context.set_verify | ||
OpenSSL.crypto | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stubtest complains that
OpenSSL.crypto
doesn't exist. If you don't want to figure out what's going on with that, you can leaveOpenSSL.crypto
in the allowlist for this PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems I've figured out what's going on and proposed a fix:
python/mypy#10663