Update pwd stub file #5741
Merged
Update pwd stub file #5741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the following properties to struct_passwd: * n_fields * n_sequence_fields * n_unnamed_fields To fix the following errors: * pwd.struct_passwd.n_fields is not present in stub * pwd.struct_passwd.n_sequence_fields is not present in stub * pwd.struct_passwd.n_unnamed_fields is not present in stub
This comment has been minimized.
This comment has been minimized.
|
Could you reformat with Black? |
|
Yes I could reformat with Black --Nsukami_
|
This comment has been minimized.
This comment has been minimized.
|
I see there Is the Pillow error: But :\ |
|
PIL error is unrelated to this PR. See #5746 |
srittau
requested changes
Jul 9, 2021
stdlib/pwd.pyi
Outdated
Comment on lines
11
to
16
| @property | ||
| def n_fields(self) -> int: ... | ||
| @property | ||
| def n_sequence_fields(self) -> int: ... | ||
| @property | ||
| def n_unnamed_fields(self) -> int: ... |
There was a problem hiding this comment.
These are actually class properties:
srittau@blitz:~$ python3
Python 3.7.3 (default, Jan 22 2021, 20:04:44)
[GCC 8.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import pwd
>>> pwd.struct_passwd.n_fields
7
>>> 
There was a problem hiding this comment.
Maybe:
Suggested change
| @property | |
| def n_fields(self) -> int: ... | |
| @property | |
| def n_sequence_fields(self) -> int: ... | |
| @property | |
| def n_unnamed_fields(self) -> int: ... | |
| n_fields: ClassVar[int] | |
| n_sequence_fields: ClassVar[int] | |
| n_unnamed_fields: ClassVar[int] |
You will need to add from typing import ClassVar.
This comment has been minimized.
This comment has been minimized.
…elds properties Those properties are not simple integers, they are also class variables.
srittau
approved these changes
Jul 9, 2021
|
You need to run |
This comment has been minimized.
This comment has been minimized.
|
Thanks a lot for your time, advices & suggestions 😆 |
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the following properties to struct_passwd:
To fix the following errors: