-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
tornado: add some types #5742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
tornado: add some types #5742
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
f641269
tornado: add some types
JelleZijlstra 0282032
add Type
JelleZijlstra f69dd65
maybe fix stubtest
JelleZijlstra 839820a
Merge remote-tracking branch 'upstream/master' into aenter
JelleZijlstra db17a0d
set version, add more types
JelleZijlstra 6933c46
no point releases
JelleZijlstra c1267ce
no async def in Python 2
JelleZijlstra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,8 @@ | ||
| from typing import Any, Optional | ||
| from types import TracebackType | ||
| from typing import Any, NoReturn, Optional, Type | ||
|
|
||
| class _TimeoutGarbageCollector: | ||
| def __init__(self): ... | ||
| def __init__(self) -> None: ... | ||
|
|
||
| class Condition(_TimeoutGarbageCollector): | ||
| io_loop: Any | ||
|
|
@@ -11,35 +12,37 @@ class Condition(_TimeoutGarbageCollector): | |
| def notify_all(self): ... | ||
|
|
||
| class Event: | ||
| def __init__(self): ... | ||
| def is_set(self): ... | ||
| def __init__(self) -> None: ... | ||
| def is_set(self) -> bool: ... | ||
| def set(self): ... | ||
| def clear(self): ... | ||
| def wait(self, timeout: Optional[Any] = ...): ... | ||
|
|
||
| class _ReleasingContextManager: | ||
| def __init__(self, obj): ... | ||
| def __enter__(self): ... | ||
| def __init__(self, obj) -> None: ... | ||
| def __enter__(self) -> None: ... | ||
| def __exit__(self, exc_type, exc_val, exc_tb): ... | ||
|
|
||
| class Semaphore(_TimeoutGarbageCollector): | ||
| def __init__(self, value: int = ...): ... | ||
| def release(self): ... | ||
| def __init__(self, value: int = ...) -> None: ... | ||
| def release(self) -> None: ... | ||
| def acquire(self, timeout: Optional[Any] = ...): ... | ||
| def __enter__(self): ... | ||
| def __enter__(self) -> NoReturn: ... | ||
| __exit__: Any | ||
| def __aenter__(self): ... | ||
| def __aexit__(self, typ, value, tb): ... | ||
| def __aenter__(self) -> None: ... | ||
| def __aexit__( | ||
| self, typ: Optional[Type[BaseException]], value: Optional[BaseException], tb: Optional[TracebackType] | ||
| ) -> None: ... | ||
Akuli marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| class BoundedSemaphore(Semaphore): | ||
| def __init__(self, value: int = ...): ... | ||
| def release(self): ... | ||
| class BoundedSemaphore(Semaphore): ... | ||
|
|
||
| class Lock: | ||
| def __init__(self): ... | ||
| def __init__(self) -> None: ... | ||
| def acquire(self, timeout: Optional[Any] = ...): ... | ||
| def release(self): ... | ||
| def __enter__(self): ... | ||
| def release(self) -> None: ... | ||
| def __enter__(self) -> NoReturn: ... | ||
| __exit__: Any | ||
| def __aenter__(self): ... | ||
| def __aexit__(self, typ, value, tb): ... | ||
| def __aenter__(self) -> None: ... | ||
| def __aexit__( | ||
| self, typ: Optional[Type[BaseException]], value: Optional[BaseException], tb: Optional[TracebackType] | ||
| ) -> None: ... | ||
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation is:
It might be better to delete this, so that you get an error when type-checking, not at runtime.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done