Add missing stdlib xml stubs #5895
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
srittau
requested changes
Aug 9, 2021
stdlib/xml/dom/pulldom.pyi
Outdated
Comment on lines
16
to
17
| DocumentFactory = Union[DOMImplementation, None] | ||
| Node = Union[Document, Element, Text] |
There was a problem hiding this comment.
Since these are not available at runtime, they should be prefixed with _.
_DocumentFactory = Union[DOMImplementation, None]
_Node = Union[Document, Element, Text](Same for Event.)
stdlib/xml/dom/pulldom.pyi
Outdated
|
|
||
| class PullDOM(ContentHandler): | ||
| document: Any | None | ||
| documentFactory: Any | ||
| document: Union[Document, None] |
There was a problem hiding this comment.
Please use the new union syntax:
Suggested change
| document: Union[Document, None] | |
| document: Document | None |
(It doesn't work yet for the type aliases above.)
There was a problem hiding this comment.
When i use the new union syntax, some of the checks fail. Is that normal?
srittau
reviewed
Aug 9, 2021
stdlib/xml/dom/pulldom.pyi
Outdated
| def expandNode(self, node) -> None: ... | ||
| def getEvent(self): ... | ||
| def getEvent(self) -> _Event: ... | ||
| def expand_Node(self, node: _Node) -> None: ... |
There was a problem hiding this comment.
Search & replace error :)
Suggested change
| def expand_Node(self, node: _Node) -> None: ... | |
| def expandNode(self, node: _Node) -> None: ... |
There was a problem hiding this comment.
hahahahahahhaha my bad
This comment has been minimized.
This comment has been minimized.
srittau
approved these changes
Aug 9, 2021
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #3787