Skip to content

logging: fix various __init__ methods #6417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hauntsaninja merged 2 commits into from
Dec 1, 2021
Merged

logging: fix various __init__ methods #6417

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8ea32c
logging: fix various __init__ methods
Nov 28, 2021
b63afd5
use mapping
Dec 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions stdlib/logging/__init__.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,17 @@ class Formatter:
else:
default_msec_format: str

if sys.version_info >= (3, 8):
if sys.version_info >= (3, 10):
def __init__(
self,
fmt: str | None = ...,
datefmt: str | None = ...,
style: _FormatStyle = ...,
validate: bool = ...,
*,
defaults: Mapping[str, Any] | None = ...,
) -> None: ...
elif sys.version_info >= (3, 8):
def __init__(
self, fmt: str | None = ..., datefmt: str | None = ..., style: _FormatStyle = ..., validate: bool = ...
) -> None: ...
Expand Down Expand Up @@ -357,7 +367,7 @@ class LoggerAdapter(Generic[_L]):
manager: Manager # undocumented
if sys.version_info >= (3, 10):
extra: Mapping[str, object] | None
def __init__(self, logger: _L, extra: Mapping[str, object] | None) -> None: ...
def __init__(self, logger: _L, extra: Mapping[str, object] | None = ...) -> None: ...
else:
extra: Mapping[str, object]
def __init__(self, logger: _L, extra: Mapping[str, object]) -> None: ...
Expand Down Expand Up @@ -745,7 +755,10 @@ class PercentStyle(object): # undocumented
if sys.version_info >= (3, 8):
validation_pattern: Pattern[str]
_fmt: str
def __init__(self, fmt: str) -> None: ...
if sys.version_info >= (3, 10):
def __init__(self, fmt: str, *, defaults: Mapping[str, Any] | None = ...) -> None: ...
else:
def __init__(self, fmt: str) -> None: ...
def usesTime(self) -> bool: ...
if sys.version_info >= (3, 8):
def validate(self) -> None: ...
Expand Down