add ParamSpec to asyncio.to_thread

[graingert]

No description provided.

[graingert]

hmm stubtest doesn't like the ParamSpec _P here:

C:\hostedtoolcache\windows\Python\3.9.9\x64\python.exe -m mypy.stubtest --check-typeshed --custom-typeshed-dir . --allowlist tests\stubtest_allowlists\py3_common.txt --allowlist tests\stubtest_allowlists\py39.txt --allowlist tests\stubtest_allowlists\win32.txt --allowlist tests\stubtest_allowlists\win32-py39.txt --ignore-positional-only
error: not checking stubs due to mypy build errors:
stdlib\asyncio\threads.pyi:9: error: Name "_P.args" is not defined
stdlib\asyncio\threads.pyi:9: error: Name "_P.kwargs" is not defined

[JelleZijlstra]

I just merged a PR upgrading stubtest to 0.930, let's see if that helps.

[github-actions]

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

[Akuli]

It might be good to remove # type: ignore comments from other uses of ParamSpec, as they no longer seem to be necessary. CONTRIBUTING.md should be updated too.

[graingert]

It might be good to remove # type: ignore comments from other uses of ParamSpec, as they no longer seem to be necessary. CONTRIBUTING.md should be updated too.

Can CI check for unused ignores?

[srittau]

Can CI check for unused ignores?

Unfortunately not, because different type checkers might have different opinions about that.