-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Improve toml
typings
#7146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve toml
typings
#7146
Conversation
Add `toml`'s full API. Fixes #6484.
I'm not sure if it is correct to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! toml
is now deprecated and many projects are switching to tomli
instead, but we still accept improvements to the toml
stubs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! It has turned out to be trickier than I expected :)
Finally, Got the tests to pass 😄! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple final things, then this will be ready :)
Both import styles are acceptable. If one produces better syntax highlighting than the other, use whichever highlights better :) |
Provide better highlighting in code editors to recognize exported functions and classes as them instead of variables
Okay then, I think this is it! 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This is about |
Add
toml
's full API. Fixes #6484.