fix: add missing multiprocessing.popen_forkserver.pyi stubs #8425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
AlexWaygood
reviewed
Jul 28, 2022
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Alex Waygood <[email protected]>
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
|
Thanks :) two more to go and the module will be complete 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
X-Ref: #6799
This adds best-effort types to multiprocessing.popen_fork to continue to address issue #6799
The source file can be viewed here:
https://github.com/python/cpython/blob/main/Lib/multiprocessing/popen_forkserver.py
Note that the forkserver version inherits from
popen_fork, so_launchis called explicitly as was the case there. This only includes new or overriding attributes on thePopenclass, ignoring attributes likepidwhich are identical with the parent.sentinelis defined here even though it matchespopen_fork.Popenbecause it doesn't have the same condition as the comment in the other stub.