refactor: update emoji package to 2.0.0 #8426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
|
The pyright failure was: Fixed the missing at runtime error I had missed though |
This comment has been minimized.
This comment has been minimized.
30 tasks
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
|
If you fancy tackling #8360, that would also be a very welcome PR :) |
|
I'll take a look at what that requires. I think that'll be much more straightforward for me than trying to handle #4776, as I don't have enough experience with peewee to feel confident I'll get it right without starting them over from scratch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #8359
This updates the stubs for the emoji package to 2.0.0
Parts of the
EMOJI_DICTcould beTypeDict'd but I don't think there is support for the attribute may exist or may not exist to appropriately do that typing, so I've marked the inner-dict as Incomplete.