-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add SearchableAPIResource and SearchResultObject for types-stripe #8696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SearchableAPIResource and SearchResultObject for types-stripe #8696
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Are some of these things new in |
This comment has been minimized.
This comment has been minimized.
@AlexWaygood The overall feature isn't new to v4, but the way I'm typing it is not technically accurate? The I would like to make this change without updating to v4. Would I be able to add an exception for this for now? Or should I add types for each subclass? |
Yeah that should be fine! Sorry for the delayed response! We do that for a few other classes, e.g.: typeshed/tests/stubtest_allowlists/py3_common.txt Lines 101 to 102 in b4d9105
You'll just need to add some entries to https://github.com/python/typeshed/blob/master/stubs/stripe/%40tests/stubtest_allowlist.txt to get the CI happy with it :) |
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good! Just one suggestion, and two questions
stubs/stripe/stripe/api_resources/abstract/searchable_api_resource.pyi
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!!
Thank you for the help!! :) |
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Add type annotations for
SearchableAPIResource
andSearchResultObject
for the stripe library stubs, and addSearchableAPIResource
inheritance for relevant classes.Fixes stripe/stripe-python#871