Skip to content

stubtest_third_party.py: Make it work on Windows #8720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2022
Merged

Conversation

AlexWaygood
Copy link
Member

No description provided.

@Akuli
Copy link
Collaborator

Akuli commented Sep 10, 2022

Is there a reason to run the script locally?

@AlexWaygood
Copy link
Member Author

AlexWaygood commented Sep 10, 2022

Is there a reason to run the script locally?

I've never felt a need to. However, here's a few reasons why I think this change would be worthwhile:

  • tests/README.md advertises it as a test that can be run locally. If we don't want to fix it so it's runnable on Windows, we should probably amend the docs to clarify that it can only be run locally if you're on a non-Windows platform.
  • If you're contributing stubs for a new package (something I've only done once), you might plausibly have a good reason for running this script locally before filing a PR. The "create a clean virtual environment for testing, then automatically delete the virtual environment after you've finished testing" feature seems quite useful.
  • If we merge Added stubs for D3DShot #8652, we'll probably want to add a way to stubtest at least some third-party packages on Windows in CI (#8660), since D3DShot is a Windows-only package. This change will be necessary if we want to start stubtesting third-party packages on Windows in CI.

Copy link
Collaborator

@Akuli Akuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function has quite a few local variables, but refactoring it is beyond the scope of this PR.

@Akuli Akuli merged commit ed29fc5 into master Sep 10, 2022
@Akuli Akuli deleted the stubtest-windows branch September 10, 2022 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants