Skip to content

Link earliest version with py.typed in stubsabot obsoletion PRs #8775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 20, 2022

Conversation

AlexWaygood
Copy link
Member

Fixes #8754.

In order to fix that bug, this PR introduces a new abstraction, a PypiReleaseDownload class. Instances of this class represent specific releases of a PyPI distribution, and various pieces of information relevant to that specific release. The version and upload_date attributes have been moved from the PypiInfo class to this new class, since now we potentially need to download multiple versions of the same package from PyPI.

Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@hauntsaninja hauntsaninja changed the title Fix bug in stubsabot obsoletion PRs Link earliest version with py.typed in stubsabot obsoletion PRs Sep 20, 2022
@AlexWaygood AlexWaygood merged commit 2e50b58 into python:master Sep 20, 2022
@AlexWaygood AlexWaygood deleted the stubsabot-obsoletion-bug branch September 20, 2022 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stubsabot obsoletion PRs: erroneous assumptions that the latest release is the one that added a py.typed
2 participants