add boltons #8892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

AlexWaygood merged 68 commits into python:main from AABur:boltons

Jun 7, 2023

Contributor

AABur commented Oct 13, 2022

add stubs for boltons library

AABur added 10 commits

October 12, 2022 23:55


          update gitignore

9680e81


          add auto-generated stubs for boltons

a6800a3


          update dictutils/FrozenDict

ede7ad0


          update dictutils/FrozenHashError

0d7f4ff


          update dictutils/subdict

d40ab5d


          update dictutils/ManyToMany

04ab8fd


          update dictutils/OneToOne

24c1590


          update dictutils/FastIterOrderedMultiDict

0c90a6e


          update dictutils/OrderedMultiDict

76b5e8b


          format code

af3dbb9

Contributor Author

AABur commented Oct 13, 2022

@sobolevn
Please review the bolton/dictutils stubs
This is my first PR in typeshed and there is for sure room for improvement.

This comment has been minimized.

Sign in to view

sobolevn previously requested changes

View reviewed changes

Member

sobolevn left a comment

Thanks, this is good start.

I think we would need to:

Fix flake8. Right now it says:

 ./stubs/boltons/boltons/timeutils.pyi:46:20: F821 undefined name 'DSTEND_1987_2006'
./stubs/boltons/boltons/funcutils.pyi:45:5: F811 redefinition of unused 'get_sig_str' from line 43
./stubs/boltons/boltons/funcutils.pyi:46:5: F811 redefinition of unused 'get_invocation_str' from line 44
./stubs/boltons/boltons/funcutils.pyi:54:5: F811 redefinition of unused 'add_arg' from line 53
./stubs/boltons/boltons/urlutils.pyi:92:1: F811 redefinition of unused 'OrderedMultiDict' from line 5
./stubs/boltons/boltons/deprutils.pyi:5:26: F821 undefined name 'ModuleType'
./stubs/boltons/boltons/ioutils.pyi:5:13: F821 undefined name 'unicode'
./stubs/boltons/boltons/tbutils.pyi:3:8: F821 undefined name 'unicode'
./stubs/boltons/boltons/fileutils.pyi:50:12: F821 undefined name 'copy_tree'
./stubs/boltons/boltons/iterutils.pyi:66:5: F811 redefinition of unused '__next__' from line 65
./stubs/boltons/boltons/iterutils.pyi:72:5: F811 redefinition of unused 'reseed' from line 71

You need to define / import all missing names.

Mypy and other tools must pass, there are multiple issues there at the moment. For example,

stubs/boltons/boltons/listutils.pyi:26: note:      Superclass:
stubs/boltons/boltons/listutils.pyi:26: note:          @overload
stubs/boltons/boltons/listutils.pyi:26: note:          def sort(self, *, key: None = ..., reverse: bool = ...) -> None
stubs/boltons/boltons/listutils.pyi:26: note:          @overload
stubs/boltons/boltons/listutils.pyi:26: note:          def sort(self, *, key: Callable[[Any], Union[SupportsDunderLT[Any], SupportsDunderGT[Any]]], reverse: bool = ...) -> None
stubs/boltons/boltons/listutils.pyi:26: note:      Subclass:
stubs/boltons/boltons/listutils.pyi:26: note:          def sort(self) -> None

The only way to fix it is to add # type: ignore to the method definition line: def sort(self) -> None: # type: ignore

stubs/boltons/boltons/cacheutils.pyi Outdated Show resolved Hide resolved

stubs/boltons/boltons/cacheutils.pyi Outdated Show resolved Hide resolved

stubs/boltons/boltons/cacheutils.pyi Outdated Show resolved Hide resolved

stubs/boltons/boltons/iterutils.pyi Outdated Show resolved Hide resolved

stubs/boltons/boltons/iterutils.pyi Outdated Show resolved Hide resolved

stubs/boltons/boltons/tbutils.pyi Outdated Show resolved Hide resolved

AABur added 2 commits

October 16, 2022 00:21


          fix linter warnings

f120ae7


          fix linter warnings

9ee21c5

This comment has been minimized.

Sign in to view

Contributor Author

AABur commented Oct 16, 2022

flake8 & mypy FIXED

--- TEST SUMMARY: One or more tests failed. See above for details. ---

Flake8: Success
Check consistent: Success
Check new syntax: Success
Pyright: Success
mypy: Success
stubtest: Failed
pytype: Success
Regression test: Success

Time to dive into designing the correct stubs

AABur and others added 2 commits

October 27, 2022 12:48


          Merge branch 'python:master' into boltons

b6d5968


          Make changes to pass flake8 (#2)

416ba9c

This comment has been minimized.

Sign in to view

Member

AlexWaygood commented Nov 8, 2022

Thanks @AABur. Are you able to take a look at the stubtest errors in CI? Please say if you need guidance on any of them :)


          Merge branch 'python:main' into boltons

007b6d1

This comment has been minimized.

Sign in to view


          boltons: fix stubtest errors

2155b12

This comment has been minimized.

Sign in to view

AlexWaygood reviewed

View reviewed changes

stubs/boltons/@tests/stubtest_allowlist.txt Outdated Show resolved Hide resolved


          remove unused allowlist entry

211c8d0

This comment has been minimized.

Sign in to view


          Merge branch 'python:main' into boltons

155c216

This comment has been minimized.

Sign in to view

Contributor

github-actions bot commented Mar 31, 2023

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉


          update listutils

abb2d21

Contributor

github-actions bot commented Mar 31, 2023

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

AABur added 2 commits

April 1, 2023 00:55


          update tbutils and typeutils

019b6a9


          update dictutils and tbutils

a536c53

Contributor

github-actions bot commented Apr 1, 2023

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉


          update setutils and socketutils

69e8767

AABur requested a review from AlexWaygood

April 17, 2023 20:07

Contributor

github-actions bot commented Apr 27, 2023

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉


          boltons: update cacheutils

f48d187

Contributor

github-actions bot commented May 17, 2023

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉


          Merge branch 'main' into boltons

ef5c948

Contributor

github-actions bot commented May 18, 2023

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

JelleZijlstra and others added 6 commits

June 6, 2023 20:31


          Many fixes

9d1128c


          Merge remote-tracking branch 'upstream/main' into boltons

5cfc655


          black

f60417c


          stubdefaulter

700ab61


          black

f7b8936


          [pre-commit.ci] auto fixes from pre-commit.com hooks

c83e076

Member

JelleZijlstra commented Jun 7, 2023

I went over the code locally and made a number of changes:

Target boltons 23.0.0, which has now been released
Remove various compatibility aliases (e.g., unicode) that shouldn't be used directly
Fix many incorrect uses of NoReturn
Fix various other incorrect types
Add some missing types

Stubtest will probably have some complaints

Contributor

github-actions bot commented Jun 7, 2023

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

JelleZijlstra added 2 commits

June 6, 2023 20:45


          Some mypy fixes

de2d52a


          stubtest fixes

8479b28

JelleZijlstra approved these changes

View reviewed changes

Member

JelleZijlstra left a comment

There may be some more issues, but I think I caught most of them.

@AlexWaygood do you want to take another look?

Contributor

github-actions bot commented Jun 7, 2023

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

AlexWaygood dismissed their stale review

June 7, 2023 06:52

I trust Jelle

Member

AlexWaygood commented Jun 7, 2023

There may be some more issues, but I think I caught most of them.

@AlexWaygood do you want to take another look?

If you're happy, I'm happy :)

Let's merge this now

AlexWaygood merged commit 46de19d into python:main

Member

sobolevn commented Jun 7, 2023

Congrats @AABur 🎉

Member

sobolevn commented Jun 7, 2023

@kyawgyi99996 what kind of help do you need?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet