Complete stubtest for aiofiles + fix on Windows
#9184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
| @@ -17,6 +17,7 @@ _T = TypeVar("_T") | |||
| class AsyncSpooledTemporaryFile(AsyncBase[_T]): | |||
| def fileno(self) -> Generator[Incomplete, Incomplete, Incomplete]: ... | |||
| def rollover(self) -> Generator[Incomplete, Incomplete, Incomplete]: ... | |||
| async def close(self, *args: Incomplete, **kwargs: Incomplete) -> None: ... | |||
There was a problem hiding this comment.
Suggested change
| async def close(self, *args: Incomplete, **kwargs: Incomplete) -> None: ... | |
| async def close(self) -> None: ... |
This gets delegated to the underlying file's close() method.
There was a problem hiding this comment.
Thanks, I wasn't sure of the exact signature. I'll add an allowlist entry.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set
ignore_missing_stub = false, added a missing method and property, and fixed stubtest runs on Windows.I did not add
darwintoplatformsbecause it would be redundant withlinux. But I still added astubtest_allowlist_darwin.txtfor those who would like to run it locally on macos. (This is the edge case mentioned in #9173 )