Conversation
|
What would the use of
|
|
I think we've learned in the past that typing.py should be kept simple, stupid. A static checker can reject List[NoReturn]. |
Yes, right :-) Since this case is not obvious, we can let type checkers decide. |
|
Code LGTM. I wonder though if we should get Mark Shannon's view of the PEP 484 changes first. |
|
There is no hurry with this (this could not go into 3.6.1), let us first sort out the PEP, and then I could merge this. |
|
Feel free to merge as soon as 3.6.1 is released. (And typing 3.6.1 has been pushed to PyPI.) |
Fixes #165
Note that here I prohibit
List[NoReturn], but maybe we should allow this in order to allowUnion[int, NoReturn]and/orCallable[..., NoReturn](or make exceptions for the latter two).As discussed in #165, this PR should wait until Python 3.6.1 is released.