Skip to content

Optional NewType Validation #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

Optional NewType Validation #416

wants to merge 9 commits into from

Conversation

davidroeca
Copy link

@davidroeca davidroeca commented Apr 26, 2017

One proposed implementation of #415

This should work as indicated by the docstring as long as this would make sense to mypy.

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@gvanrossum
Copy link
Member

I just have to say that this is not as easy as you think. I don't have time to elaborate, sorry.

@davidroeca
Copy link
Author

Agreed that this likely touches a number of first and third-party libraries, and that NewType should be limited in scope. Figured this could at least be a point of discussion, and finally people have responded to my issue so I believe this pull request has done its work.

@davidroeca davidroeca closed this Apr 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants