Changing to Pyglet from Soloud for Sound #746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for Windows/Linux without using ffmpeg
This was referenced Sep 4, 2020
|
We should probably try to get this one merged soon. There are some PyWeekers bumping into audio problems. |
* issue #782 faster checking for line of sight between Sprites * issue #782 faster checking for line of sight between Sprites 1. shapely and setuptools removed from requirements.txt * Update requirements.txt removed all versioning. Co-authored-by: akapkotel <[email protected]>
…y_to_find_line_of_sight (#788) 1. Replaced all geometry collision test with shapely functions. 2. Replaced math.sqrt function with math.hypot in get_distance function because hypot is faster - see math module documentation. 3. Removed some redundant local assignments in sprite_list.py functions with straightforward returns. Co-authored-by: akapkotel <[email protected]>
* Updates to setuptools configuration to align with PEP 517 * chore(setup): remove trailing comma * Pin crucial package versions * Update MANIFEST to include .typed files. * Finalize package version pins.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change re-works the sound module a bit, primarily abstracting the back-end behind a common interface, and switching from the SoLoud library to Pyglet. It has been tested against Windows, Mac, and Linux with .wav, .mp3, and .ogg formats.
There are no API breaking changes and everything should be able to use it in the same way as previously. However there are some feature additions.
Added Features:
This should also greatly improve cross-platform support.
The ffmpeg binaries for Mac have been added in a similar fashion to how SoLoud's binaries were included. They can be seen in the "arcade/lib" folder. If ffmpeg is desired for Windows/Linux all one would need to do is drop the corresponding binaries into there and they would automatically be loaded. The Windows/Linux binaries have not been included due Pyglet having out of the box support for Windows/Linux