Skip to content

Make tar file for generated files and an option to download #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ydcjeff opened this issue Mar 9, 2021 · 2 comments · Fixed by #6
Closed

Make tar file for generated files and an option to download #2

ydcjeff opened this issue Mar 9, 2021 · 2 comments · Fixed by #6
Assignees
@ydcjeff
Labels
backend Backend: code gen etc enhancement New feature or request frontend Vue app

Comments

@ydcjeff
Copy link
Member

ydcjeff commented Mar 9, 2021

Currently, Code Generator has generated the files with given option from left sidebar.
Idea is make a tar file for generated files and an option to download.
@ydcjeff ydcjeff self-assigned this Mar 9, 2021
@trsvchn
Copy link
Member

trsvchn commented Mar 10, 2021 •
edited
Loading

Some pro tip (sorry if its smth obvious :) but I was surprised when I discovered it)
python already has a make_archive fn hidden in shutil module:

https://docs.python.org/3.8/library/shutil.html#shutil.make_archive

@ydcjeff
Copy link
Member Author

ydcjeff commented Mar 10, 2021

Thanks @trsvchn I didn't know that either

@ydcjeff ydcjeff mentioned this issue Mar 10, 2021
Merged
@trsvchn trsvchn added backend Backend: code gen etc enhancement New feature or request frontend Vue app labels Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ydcjeff ydcjeff

Labels
backend Backend: code gen etc enhancement New feature or request frontend Vue app
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(download): add an option to archive and download pytorch-ignite/code-generator
2 participants
@trsvchn @ydcjeff