Skip to content

Few improvements #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vfdev-5 opened this issue Mar 31, 2021 · 3 comments
Closed

Few improvements #32

vfdev-5 opened this issue Mar 31, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@vfdev-5
Copy link
Member

vfdev-5 commented Mar 31, 2021

Currently tested on master: 78b0def

  • requirements-dev.txt is missing the entry -r requirements.txt to install streamlit with appropriate version
-r requirements.txt
# dev
pytorch-ignite
torch
torchvision
jinja2
requests

# test
pytest
hypothesis
  • Change text: "Those in the parenthesis are used in the generated code." -> "Names in the parenthesis are variable names in the generated code." or something similar.

  • Let's explicitly create the trainer in CIFAR10 example to show how to write training_step

  • Let's add AMP option

  • Let's add Error metric (to show how we can do metrics arithmetics) :

    accuracy_metric = Accuracy(device=device)
    metrics = {
        'eval_accuracy': accuracy_metric,
        'eval_loss': Loss(loss_fn=loss_fn, device=device),
        'eval_error': (1.0 - accuracy_metric) * 100
    }
  • Let's change the output of initialize and also set up a LR scheduler:
- device, model, optimizer, loss_fn = initialize(config)
+ device = idist.device()
+ model, optimizer, loss_fn, lr_scheduler = initialize(config)
  • Distributed option if used as multiprocessing schema: python main.py -> multiple childs have/had a certain issue with dataloaders: first iteration of each epoch is very slow. To avoid that let's prefer to say to the user to lauch things with torch.distributed.launch

  • I think this code is useless to add to main.py if exp_logger is None

    # --------------------------------
    # setup common experiment loggers
    # --------------------------------
    exp_logger = setup_exp_logging(
        config=config,
        eval_engine=eval_engine,
        train_engine=train_engine,
        optimizer=optimizer,
        name=name
    )
  • I'm a bit confused about this option: eval_max_epochs and its value = 2. It is something I've never seen before. I think that we have to follow the standard practices and by default run once on the validation dataloader. Thoughts ?

  • If possible make sidebar resizable from a min possible to a max value.

@ydcjeff ydcjeff self-assigned this Mar 31, 2021
@ydcjeff ydcjeff added the enhancement New feature or request label Mar 31, 2021
@ydcjeff ydcjeff added this to the v0.1.0 milestone Mar 31, 2021
ydcjeff pushed a commit that referenced this issue Mar 31, 2021
@ydcjeff
Copy link
Member

ydcjeff commented Mar 31, 2021

requirements-dev.txt is missing the entry -r requirements.txt to install streamlit with appropriate version

Change text: "Those in the parenthesis are used in the generated code." -> "Names in the parenthesis are variable names in the generated code." or something similar.

Let's explicitly create the trainer in CIFAR10 example to show how to write training_step

Let's add AMP option

Done in 04787b1

Let's change the output of initialize and also set up a LR scheduler

Done in 2a541da

Distributed option if used as multiprocessing schema: python main.py -> multiple childs have/had a certain issue with dataloaders: first iteration of each epoch is very slow. To avoid that let's prefer to say to the user to lauch things with torch.distributed.launch

Done in e4e9023

I think this code is useless to add to main.py if exp_logger is None

Single Model, Single opt also has like that, but defaults TensorBoard.

I'm a bit confused about this option: eval_max_epochs and its value = 2. It is something I've never seen before. I think that we have to follow the standard practices and by default run once on the validation dataloader. Thoughts ?

added that as an option for configurations, removed in Single model, single opt

If possible make sidebar resizable from a min possible to a max value.

current streamlit cannot do that yet. (streamlit/streamlit#2058)

@ydcjeff ydcjeff closed this as completed in ca80e3d Apr 2, 2021
@vfdev-5
Copy link
Member Author

vfdev-5 commented Apr 3, 2021

Change text: "Those in the parenthesis are used in the generated code." -> "Names in the parenthesis are variable names in the generated code." or something similar.

@ydcjeff this should be done for all templates.

@vfdev-5 vfdev-5 reopened this Apr 3, 2021
@vfdev-5
Copy link
Member Author

vfdev-5 commented May 25, 2021

I think we can close this issue as unrelated.

@vfdev-5 vfdev-5 closed this as completed May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants