Skip to content

refactor: explicit template for image classification #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 16, 2021
Merged

Conversation

ydcjeff
Copy link
Contributor

@ydcjeff ydcjeff commented Mar 16, 2021

Explicit template code instead of extending from base template. This PR

  • Add wandb logging system
  • Add save_best_model_by_val_score and setup_common_training_handlers
  • Removed metadata.json and generate_metadata.json and define template config in {template}_sidebar.py
  • Renamed {template}_config.py to {template}_sidebar.py
  • Commented out amp_mode since ignite latest is v0.4.4
  • device is automatically determined via idist.device()

cc: @pytorch-ignite/project-leaders

@ydcjeff ydcjeff added this to the v0.1.0 milestone Mar 16, 2021
@trsvchn
Copy link
Member

trsvchn commented Mar 16, 2021

So, no more inheritance?

@ydcjeff
Copy link
Contributor Author

ydcjeff commented Mar 16, 2021

So, no more inheritance?

Yes, I chose that way as I found overwriting some parts looks a little weird to me and make easy for contributors who might not know jinja. This would require almost same and more work if templates need to update same configs (like supporting hydra)

What do you think ?

@trsvchn
Copy link
Member

trsvchn commented Mar 16, 2021

I like it, I am not big fan of inheritance as a concept)

@trsvchn
Copy link
Member

trsvchn commented Mar 16, 2021

LGTM!

@ydcjeff ydcjeff merged commit 5122bff into master Mar 16, 2021
@ydcjeff ydcjeff deleted the explicit-code branch March 16, 2021 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants