Skip to content

feat: add 404 not found page #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 5, 2021
Merged

feat: add 404 not found page #178

merged 7 commits into from
Oct 5, 2021

Conversation

afzal442
Copy link
Contributor

@afzal442 afzal442 commented Oct 3, 2021 •
edited
Loading

Signed-off-by: afzal442 [email protected]

Description

Fix #170

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New feature
  • Other

@afzal442
adds 404 pagenotfound
74d3258 
Signed-off-by: afzal442 <[email protected]>
@netlify
Copy link

netlify bot commented Oct 3, 2021 •
edited
Loading

✔️ Deploy Preview for code-generator ready!

🔨 Explore the source changes: d2bb320

🔍 Inspect the deploy log: https://app.netlify.com/sites/code-generator/deploys/615a7c4a92813900076680b2

😎 Browse the preview: https://deploy-preview-178--code-generator.netlify.app/

@afzal442

This comment has been minimized.

Sign in to view
@trsvchn
Copy link
Member

trsvchn commented Oct 3, 2021

Thanks @afzal442!
Let me run the deploy preview!

@trsvchn
Copy link
Member

trsvchn commented Oct 3, 2021

@afzal442 Looks like we have some linting issues here

https://github.com/pytorch-ignite/code-generator/pull/178/checks?check_run_id=3781076007#step:9:13

Please take a look at our CONTRIBUTING how to run formatters.

@trsvchn
Copy link
Member

trsvchn commented Oct 3, 2021 •
edited
Loading

Thanks @afzal442 ! It works!
https://deploy-preview-178--code-generator.netlify.app/foo

But let's try to add top bar and a footer, to get smth like this:
404page

Inspired by pytorch 404 page

@afzal442
Copy link
Contributor Author

afzal442 commented Oct 3, 2021

@trsvchn I am done. 🪧 Plz also add hacktoberfest label as well. 😵‍💫

@afzal442
minor changes
e805934 
Signed-off-by: afzal442 <[email protected]>
@trsvchn
Copy link
Member

trsvchn commented Oct 3, 2021

Thanks @afzal442 ! This looks much better :)

Let's split the page content into several lines, to fit into the following template:

Error Code

Error Short Description

Error Long Description

How to solve

navbar

404

Page Not Found

Oops we couldn't find that page.

Try going home

footer

trsvchn
trsvchn reviewed Oct 3, 2021
View reviewed changes
Copy link
Member

@trsvchn trsvchn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @afzal442 !

I left some nit comments related to wording.

@afzal442
minor changes fixed
561db62 
Signed-off-by: afzal442 <[email protected]>
@vfdev-5 vfdev-5 requested a review from ydcjeff October 3, 2021 13:27
trsvchn
trsvchn reviewed Oct 3, 2021
View reviewed changes
@afzal442
minor typo fixed
0055ecc 
Signed-off-by: afzal442 <[email protected]>
@ydcjeff ydcjeff changed the title Added 404 page not found feat: add 404 not found page Oct 4, 2021
ydcjeff
ydcjeff reviewed Oct 4, 2021
View reviewed changes
@ydcjeff ydcjeff added the hacktoberfest Hacktoberfest label Oct 4, 2021
@afzal442 afzal442 requested a review from ydcjeff October 4, 2021 15:27
@ydcjeff ydcjeff merged commit e6fa807 into pytorch-ignite:main Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trsvchn trsvchn trsvchn left review comments

@ydcjeff ydcjeff Awaiting requested review from ydcjeff

Assignees
No one assigned
Labels
hacktoberfest Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add 404 page
3 participants
@afzal442 @trsvchn @ydcjeff