Skip to content

Update ci.yml #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 1, 2023
Merged

Update ci.yml #220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2ebbef0
Update ci.yml
vfdev-5 Feb 1, 2023
f6a07d5
Updated code formatting and fixed CI (#221)
vfdev-5 Feb 1, 2023
fd810be
Updated netlify build env
vfdev-5 Feb 1, 2023
1cb1859
added --expect 200
vfdev-5 Feb 1, 2023
f4e2a9f
Added fix for Node17+, https://github.com/bahmutov/start-server-and-t…
vfdev-5 Feb 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,13 @@ jobs:
test: launch
steps:
- uses: actions/checkout@v3
- uses: actions/setup-python@v3
- uses: actions/setup-python@v4
with:
python-version: 3.6
python-version: 3.9

- uses: actions/setup-node@v3
with:
node-version: 14
node-version: 18

- uses: actions/cache@v3
with:
Expand Down Expand Up @@ -88,13 +88,13 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-python@v3
- uses: actions/setup-python@v4
with:
python-version: 3.8
python-version: 3.9

- uses: actions/setup-node@v3
with:
node-version: 14
node-version: 16

- uses: actions/cache@v3
with:
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ To add a new template,
pnpm run lint
```

- To ensure the codebase complies with a style guide, we use black and isort tools to format and check codebase for compliance with PEP8. Install and run with:
- To ensure the codebase complies with a style guide, we use black and ufmt to format and check codebase for compliance with PEP8. Install and run with:

```sh
# install code formatting dependencies
Expand Down
4 changes: 4 additions & 0 deletions netlify.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
[build.environment]
NODE_VERSION = "18"
PYTHON_VERSION = "3.8"

[build]
publish = "./dist"
command = "npx pnpm i --frozen-lockfile --store=node_modules/.pnpm-store && npx pnpm run build"
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"build": "vite build",
"serve": "vite preview",
"test": "jest --color --runInBand",
"test:ci": "start-server-and-test serve 5000 test",
"test:ci": "start-server-and-test --expect 200 serve http://127.0.0.1:5000 test",
"release": "node scripts/release.js",
"fmt": "prettier --write . && bash scripts/run_code_style.sh fmt",
"lint": "prettier --check . && bash scripts/run_code_style.sh lint",
Expand All @@ -32,7 +32,7 @@
"prismjs": "^1.26.0",
"prompts": "^2.4.2",
"semver": "^7.3.5",
"start-server-and-test": "^1.14.0",
"start-server-and-test": "^1.15.3",
"uuid": "^8.3.2",
"vite": "^2.7.13",
"vue": "^3.2.30",
Expand Down
Loading