Skip to content

Fix LRScheduler issue of PyTorch #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 17, 2023
Merged

Fix LRScheduler issue of PyTorch #241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e78ef13
Fix LRScheduler issue of PyTorch
theory-in-progress May 16, 2023
2ff94c2
Fix lint
theory-in-progress May 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/templates/template-text-classification/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,14 @@
from ignite.utils import manual_seed
from models import TransformerModel
from torch import nn, optim
from torch.optim.lr_scheduler import _LRScheduler
from trainers import setup_evaluator, setup_trainer
from utils import *

try:
from torch.optim.lr_scheduler import _LRScheduler as PyTorchLRScheduler
except ImportError:
from torch.optim.lr_scheduler import LRScheduler as PyTorchLRScheduler

os.environ["TOKENIZERS_PARALLELISM"] = "false" # remove tokenizer paralleism warning


Expand Down Expand Up @@ -78,10 +82,10 @@ def run(local_rank: int, config: Any):
(config.output_dir / "config-lock.yaml").write_text(yaml.dump(config))
trainer.logger = evaluator.logger = logger

if isinstance(lr_scheduler, _LRScheduler):
if isinstance(lr_scheduler, PyTorchLRScheduler):
trainer.add_event_handler(
Events.ITERATION_COMPLETED,
lambda engine: cast(_LRScheduler, lr_scheduler).step(),
lambda engine: cast(PyTorchLRScheduler, lr_scheduler).step(),
)
elif isinstance(lr_scheduler, LRScheduler):
trainer.add_event_handler(Events.ITERATION_COMPLETED, lr_scheduler)
Expand Down
11 changes: 8 additions & 3 deletions src/templates/template-vision-segmentation/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,16 @@
from ignite.utils import manual_seed
from models import setup_model
from torch import nn, optim
from torch.optim.lr_scheduler import _LRScheduler, LambdaLR
from torch.optim.lr_scheduler import LambdaLR
from trainers import setup_evaluator, setup_trainer
from utils import *
from vis import predictions_gt_images_handler

try:
from torch.optim.lr_scheduler import LRScheduler as PyTorchLRScheduler
except ImportError:
from torch.optim.lr_scheduler import _LRScheduler as PyTorchLRScheduler


def run(local_rank: int, config: Any):
# make a certain seed
Expand Down Expand Up @@ -71,10 +76,10 @@ def run(local_rank: int, config: Any):
(config.output_dir / "config-lock.yaml").write_text(yaml.dump(config))
trainer.logger = evaluator.logger = logger

if isinstance(lr_scheduler, _LRScheduler):
if isinstance(lr_scheduler, PyTorchLRScheduler):
trainer.add_event_handler(
Events.ITERATION_COMPLETED,
lambda engine: cast(_LRScheduler, lr_scheduler).step(),
lambda engine: cast(PyTorchLRScheduler, lr_scheduler).step(),
)
elif isinstance(lr_scheduler, LRScheduler):
trainer.add_event_handler(Events.ITERATION_COMPLETED, lr_scheduler)
Expand Down