Change default Namespace to Omegaconf and new method to save config-lock.yaml for reproducibility #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for code-generator ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
vfdev-5
reviewed
Aug 19, 2023
…into omegaconfig_save_config-1
This was referenced Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to introduce OmegaConf as the default config dict for handling hyper parameters in templates. This will be great for the subsequent introduction of python-fire and hydra.
Also we try to have a new
save_configmethod as the old method usesshutil.pyand is quite limited in its scope to save an overridden config using command line. At last, we introduce a test functiontest_save_configto test saved bysave_configmethod.Additionally I plan to remove PyYaml file methods with OmegaConf methods as they work better with Python objects like PosixPath.
Additional context
What is the purpose of this pull request?