Fix for "open in colab" opens the same zip after updates #295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Perhaps the reactivity of vue is the problem and the hyperlink is not being updated
✅ Deploy Preview for code-generator ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
theory-in-progress
changed the title
vfdev-5
reviewed
Aug 20, 2023
vfdev-5
reviewed
Aug 20, 2023
|
Have you tested on the deployed PR app if it works ? |
|
Yes, it works for the open in colab button 👍 Am testing the generate link button now... |
|
For permanent code link (for wget) it should work the same way ? Let's refactor the common code and try to add tests for the nbUid if possible |
|
Yes, was refactoring the code. For now the problem of opening in colab is fixed. I will send a new PR for refactored code and tests. |
vfdev-5
approved these changes
Aug 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #291
What is the purpose of this pull request?