-
Notifications
You must be signed in to change notification settings - Fork 24
PR to improve the hash function for uuid #312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for code-generator ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Can you check if instead of parsing all files if we parse just the |
For the previous code where we hashed the So considering this, if we hash only the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @theory-in-progress !
Please make sure that CI is passing
store.config
and hashing of the whole code in the template.Additional context
Currently, uuid hashes only the current store.config, so any changes in store.config would change the uuid, but suppose we follow the steps:
What is the purpose of this pull request?