-
Notifications
You must be signed in to change notification settings - Fork 24
Fix command errors in Nebari server run for templates #317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for code-generator ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hey @vfdev-5 seems to work as expected now, can you check on your server as well once? |
![]() Is it expected to have this ? How did you test it ? @guptaaryan16 this does not work! |
Actually for other configurations like text-segmentation, it seems to work, I guess we need to delete some previous notebooks generated for |
It's very annoying that I have to discover during the review. You could have tested the first template at least |
Co-authored-by: vfdev <[email protected]>
Actually I was testing some solutions for this problem, and it seems like updating |
Commit suffix is not related to nebari option but have to be considered in general. But in general appending a commit is not a good solution as we would generate new uuid everytime someone pushes to We may want distinguish cases when the app is run from netlify PR deployement vs from code-generator.pytorch-ignite.ai/ and append commit from PR only, IMO |
Let me revert the changes for now and make a second PR for this deployment vs PR build case |
This reverts commit 73339b8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @guptaaryan16
Description
This PR is a follow up PR for the fixes in the code execution while testing in the Nebari server. Particularly we faced two issues, first if we open a template in Nebari, its default folder will be root and if it is the second template opened, then it will try to download and overwrite the previous one. This can be fixed by fixing the
nbuid-> nbuid + '-nebari'
.Also we add some extra commands that can help in creating a new directory and store templates files in that specific directory.
Fix #314
Additional context
This issue was discussed in Discord this week.
What is the purpose of this pull request?