Skip to content

fix: template file extension rename to .py #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 6, 2021
Merged

fix: template file extension rename to .py #43

merged 2 commits into from
Apr 6, 2021

Conversation

ydcjeff
Copy link
Member

@ydcjeff ydcjeff commented Apr 6, 2021

Description: I forgot to change the file extension to pyi for image classification
Since I forgot, I would like to ask @vfdev-5 and @trsvchn, whether we want to change to .py and only run code style for _sidebar.py in templates/**. What do you think?
Sorry for going back and forth for the file extensions.

@ydcjeff ydcjeff added this to the v0.1.0 milestone Apr 6, 2021
@vfdev-5
Copy link
Member

vfdev-5 commented Apr 6, 2021

whether we want to change to .py and only run code style for _sidebar.py in templates/**. What do you think?

@ydcjeff could you please develop your question ? I'm not sure to get it correctly ...

@ydcjeff
Copy link
Member Author

ydcjeff commented Apr 6, 2021

Currently, we are using .pyi for template file extension and I forgot to rename the file extensions in the image classification template, since I first made them with .py. So I was thinking to change to .py extension for contributors to contribute easily.
And if we change to .py, we need to update the run_code_style.sh.

@ydcjeff ydcjeff changed the base branch from master to test April 6, 2021 09:24
@ydcjeff ydcjeff changed the title fix: file ext to pyi for image classification fix: template file extension rename to .py Apr 6, 2021
@ydcjeff ydcjeff changed the base branch from test to master April 6, 2021 09:31
@ydcjeff ydcjeff merged commit df65ca1 into master Apr 6, 2021
@ydcjeff ydcjeff deleted the pyi branch April 6, 2021 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants