Skip to content

feat(app): add an option to include test file #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 20, 2021
Merged

feat(app): add an option to include test file #97

merged 4 commits into from
Apr 20, 2021

Conversation

ydcjeff
Copy link
Member

@ydcjeff ydcjeff commented Apr 20, 2021

Description

Add a checkbox to include test file or not

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New feature
  • Other

vfdev-5 and others added 2 commits April 20, 2021 10:02
* Making Text classification template similar to Image Classification (#92)

* Fix template sidebar

* Code style

* [skip ci] updated contributing and readme (#93)

* [skip ci] updated contributing

* [skip ci] Updated readme

Co-authored-by: Taras Savchyn <[email protected]>
@ydcjeff ydcjeff added the frontend Vue app label Apr 20, 2021
@ydcjeff ydcjeff added this to the v0.1.0 milestone Apr 20, 2021
@ydcjeff ydcjeff requested a review from vfdev-5 April 20, 2021 10:23
@vfdev-5
Copy link
Member

vfdev-5 commented Apr 20, 2021

Thanks @ydcjeff , let's put pytest as an option in the requirements

Copy link
Member

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK, thanks @ydcjeff

Copy link
Member

@trsvchn trsvchn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @ydcjeff

@vfdev-5 vfdev-5 merged commit a9d774b into dev Apr 20, 2021
@vfdev-5 vfdev-5 deleted the test-options branch April 20, 2021 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Vue app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants