Skip to content

[fbgemm_gpu] Properly disable TBE SSD tests in OSS #3548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

q10
Copy link
Contributor

@q10 q10 commented Jan 6, 2025

  • Properly disable TBE SSD tests in OSS
  • Extend ROCm test time limit to 40 minutes
  • Fix aarch64cuda Nova runs

Copy link

netlify bot commented Jan 6, 2025

Deploy Preview for pytorch-fbgemm-docs ready!

Name Link
🔨 Latest commit a05abd3
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/677ce7ab3475f5000847cd7f
😎 Deploy Preview https://deploy-preview-3548--pytorch-fbgemm-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@q10 q10 force-pushed the bm/fix-release-tests branch 3 times, most recently from 06e6d1d to 9e40862 Compare January 6, 2025 22:37
@facebook-github-bot
Copy link
Contributor

@q10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

q10 added a commit to q10/FBGEMM that referenced this pull request Jan 6, 2025
Summary:
- Properly disable TBE SSD tests in OSS    
- Extend ROCm test time limit to 40 minutes    
- Fix `aarch64cuda` Nova runs


Differential Revision: D67879826

Pulled By: q10
@q10 q10 force-pushed the bm/fix-release-tests branch from 9e40862 to e2466c8 Compare January 6, 2025 22:49
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67879826

@facebook-github-bot
Copy link
Contributor

@q10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@q10 q10 force-pushed the bm/fix-release-tests branch from 182ee3f to 6135d04 Compare January 7, 2025 07:12
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 7, 2025
Summary:
X-link: facebookresearch/FBGEMM#637

- Properly disable TBE SSD tests in OSS    
- Extend ROCm test time limit to 40 minutes    
- Fix `aarch64cuda` Nova runs


Reviewed By: jianyuh

Differential Revision: D67879826

Pulled By: q10
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67879826

Summary:
X-link: facebookresearch/FBGEMM#637

- Properly disable TBE SSD tests in OSS    
- Extend ROCm test time limit to 40 minutes    
- Fix `aarch64cuda` Nova runs


Reviewed By: jianyuh

Differential Revision: D67879826

Pulled By: q10
@q10 q10 force-pushed the bm/fix-release-tests branch from 6135d04 to a05abd3 Compare January 7, 2025 08:36
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67879826

@facebook-github-bot
Copy link
Contributor

@q10 merged this pull request in 61f3b15.

q10 added a commit to q10/FBGEMM that referenced this pull request Apr 10, 2025
Summary:
Pull Request resolved: facebookresearch/FBGEMM#637

- Properly disable TBE SSD tests in OSS
- Extend ROCm test time limit to 40 minutes
- Fix `aarch64cuda` Nova runs

X-link: pytorch#3548

Reviewed By: jianyuh

Differential Revision: D67879826

Pulled By: q10

fbshipit-source-id: 1ebf8a401b08876362a1d7f8bd29fbe3f8da2665
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants