Allow reusing input data in TBE benchmark #3594
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Add `--num-requests` in TBE's `device` benchmark to allow for input batches reuse. By default, `--num-requests` is set to -1. In this case, the benchmark will generate `iters` batches. If it is set, the benchmark will generate `num_requests` batches. If this value is smaller than `iters`, input batches will be reused (i.e., iter `i` uses batch `i % num_requests`). Differential Revision: D68340968
|
This pull request was exported from Phabricator. Differential Revision: D68340968 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sryap
added a commit
to sryap/FBGEMM
that referenced
this pull request
Jan 21, 2025
Summary: X-link: facebookresearch/FBGEMM#674 Add `--num-requests` in TBE's `device` benchmark to allow for input batches reuse. By default, `--num-requests` is set to -1. In this case, the benchmark will generate `iters` batches. If it is set, the benchmark will generate `num_requests` batches. If this value is smaller than `iters`, input batches will be reused (i.e., iter `i` uses batch `i % num_requests`). Differential Revision: D68340968
|
This pull request has been merged in 51d2be6. |
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Apr 10, 2025
Summary: Pull Request resolved: facebookresearch/FBGEMM#674 X-link: pytorch#3594 Add `--num-requests` in TBE's `device` benchmark to allow for input batches reuse. By default, `--num-requests` is set to -1. In this case, the benchmark will generate `iters` batches. If it is set, the benchmark will generate `num_requests` batches. If this value is smaller than `iters`, input batches will be reused (i.e., iter `i` uses batch `i % num_requests`). Reviewed By: gajjanag Differential Revision: D68340968 fbshipit-source-id: fdae703ec499f3ba2656cba3a3b4967c684058f5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add
--num-requestsin TBE'sdevicebenchmark to allow for inputbatches reuse. By default,
--num-requestsis set to -1. In thiscase, the benchmark will generate
itersbatches. If it is set, thebenchmark will generate
num_requestsbatches. If this value issmaller than
iters, input batches will be reused (i.e., iteriuses batch
i % num_requests).Differential Revision: D68340968