Remove FENV pragma #3629
Closed
Remove FENV pragma #3629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: X-link: facebookresearch/FBGEMM#706 We are seeing this error in an internal build: ``` fbcode/deeplearning/fbgemm/src/FbgemmFloat16ConvertSVE.cc:63:25: error: expected identifier in '#pragma FENV_ROUND' - ignored [-Werror,-Wignored-pragmas] 63 | #pragma STDC FENV_ROUND FE_TONEAREST ``` Until we figure out the floating-point environment business, let's remove this pragma. Differential Revision: D68815786
|
This pull request was exported from Phabricator. Differential Revision: D68815786 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request has been merged in 5b048ab. |
avbokovoy
pushed a commit
to ROCm/FBGEMM
that referenced
this pull request
Feb 14, 2025
Summary: Pull Request resolved: pytorch#3629 X-link: https://github.com/facebookresearch/FBGEMM/pull/706 We are seeing this error in an internal build: ``` fbcode/deeplearning/fbgemm/src/FbgemmFloat16ConvertSVE.cc:63:25: error: expected identifier in '#pragma FENV_ROUND' - ignored [-Werror,-Wignored-pragmas] 63 | #pragma STDC FENV_ROUND FE_TONEAREST ``` Until we figure out the floating-point environment business, let's remove this pragma. Reviewed By: gag1jain Differential Revision: D68815786 fbshipit-source-id: 15a8140a2d3066aded312da63b2da70061a66151
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Apr 10, 2025
Summary: X-link: pytorch#3629 Pull Request resolved: facebookresearch/FBGEMM#706 We are seeing this error in an internal build: ``` fbcode/deeplearning/fbgemm/src/FbgemmFloat16ConvertSVE.cc:63:25: error: expected identifier in '#pragma FENV_ROUND' - ignored [-Werror,-Wignored-pragmas] 63 | #pragma STDC FENV_ROUND FE_TONEAREST ``` Until we figure out the floating-point environment business, let's remove this pragma. Reviewed By: gag1jain Differential Revision: D68815786 fbshipit-source-id: 15a8140a2d3066aded312da63b2da70061a66151
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/706
We are seeing this error in an internal build:
Until we figure out the floating-point environment business, let's remove this pragma.
Differential Revision: D68815786