Fix triton group gemm for tp4 #3762
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request was exported from Phabricator. Differential Revision: D70568729 |
|
This pull request was exported from Phabricator. Differential Revision: D70568729 |
mxz297
added a commit
to mxz297/FBGEMM
that referenced
this pull request
Mar 4, 2025
Summary: X-link: facebookresearch/FBGEMM#843 For whatever reasons, there seems to be some integer overflow for this kernel on AMD, causing it to core dump with TP4 sharding for 17bx128E. On H100, there is no such problem. Differential Revision: D70568729
mxz297
added a commit
to mxz297/FBGEMM
that referenced
this pull request
Mar 4, 2025
Summary: X-link: facebookresearch/FBGEMM#843 For whatever reasons, there seems to be some integer overflow for this kernel on AMD, causing it to core dump with TP4 sharding for 17bx128E. On H100, there is no such problem. Differential Revision: D70568729
|
This pull request was exported from Phabricator. Differential Revision: D70568729 |
mxz297
added a commit
to mxz297/FBGEMM
that referenced
this pull request
Mar 4, 2025
Summary: X-link: facebookresearch/FBGEMM#843 Pull Request resolved: pytorch#3762 For whatever reasons, there seems to be some integer overflow for this kernel on AMD, causing it to core dump with TP4 sharding for 17bx128E. On H100, there is no such problem. Reviewed By: levendlee Differential Revision: D70568729
Summary: X-link: facebookresearch/FBGEMM#843 Pull Request resolved: pytorch#3762 For whatever reasons, there seems to be some integer overflow for this kernel on AMD, causing it to core dump with TP4 sharding for 17bx128E. On H100, there is no such problem. Reviewed By: levendlee Differential Revision: D70568729
|
This pull request was exported from Phabricator. Differential Revision: D70568729 |
|
This pull request has been merged in c146720. |
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Apr 10, 2025
Summary: Pull Request resolved: facebookresearch/FBGEMM#843 X-link: pytorch#3762 For whatever reasons, there seems to be some integer overflow for this kernel on AMD, causing it to core dump with TP4 sharding for 17bx128E. On H100, there is no such problem. Reviewed By: levendlee Differential Revision: D70568729 fbshipit-source-id: 7c35536d597e6801b8c1fcbceb3a0132b41b8305
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: For whatever reasons, there seems to be some integer overflow for this kernel on AMD, causing it to core dump with TP4 sharding for 17bx128E. On H100, there is no such problem.
Differential Revision: D70568729