Change the TBE bounds check to match the TBE implementation. #3773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request was exported from Phabricator. Differential Revision: D70660808 |
yyetim
pushed a commit
to yyetim/FBGEMM-1
that referenced
this pull request
Mar 5, 2025
…#3773) Summary: X-link: facebookresearch/FBGEMM#853 TBE implementation accepts weights to be zero sized to represent empty weights. Reviewed By: sryap Differential Revision: D70660808
|
This pull request was exported from Phabricator. Differential Revision: D70660808 |
yyetim
pushed a commit
to yyetim/FBGEMM-1
that referenced
this pull request
Mar 5, 2025
…#3773) Summary: X-link: facebookresearch/FBGEMM#853 Pull Request resolved: pytorch#3773 TBE implementation accepts weights to be zero sized to represent empty weights. Reviewed By: sryap Differential Revision: D70660808
yyetim
pushed a commit
to yyetim/FBGEMM-1
that referenced
this pull request
Mar 5, 2025
…#3773) Summary: X-link: facebookresearch/FBGEMM#853 TBE implementation accepts weights to be zero sized to represent empty weights. Reviewed By: sryap Differential Revision: D70660808
yyetim
pushed a commit
to yyetim/FBGEMM-1
that referenced
this pull request
Mar 5, 2025
…#3773) Summary: X-link: facebookresearch/FBGEMM#853 TBE implementation accepts weights to be zero sized to represent empty weights. Reviewed By: sryap Differential Revision: D70660808
yyetim
pushed a commit
to yyetim/FBGEMM-1
that referenced
this pull request
Mar 5, 2025
…#3773) Summary: X-link: facebookresearch/FBGEMM#853 TBE implementation accepts weights to be zero sized to represent empty weights. Reviewed By: sryap Differential Revision: D70660808
yyetim
force-pushed
the
export-D70660808
branch
2 times, most recently
from
6358607 to
9801ff9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70660808 |
yyetim
pushed a commit
to yyetim/FBGEMM-1
that referenced
this pull request
Mar 5, 2025
…#3773) Summary: X-link: facebookresearch/FBGEMM#853 Pull Request resolved: pytorch#3773 TBE implementation accepts weights to be zero sized to represent empty weights. Reviewed By: sryap Differential Revision: D70660808
|
This pull request was exported from Phabricator. Differential Revision: D70660808 |
yyetim
pushed a commit
to yyetim/FBGEMM-1
that referenced
this pull request
Mar 6, 2025
…#3773) Summary: X-link: facebookresearch/FBGEMM#853 Pull Request resolved: pytorch#3773 TBE implementation accepts weights to be zero sized to represent empty weights. Reviewed By: sryap Differential Revision: D70660808
…#3773) Summary: X-link: facebookresearch/FBGEMM#853 Pull Request resolved: pytorch#3773 TBE implementation accepts weights to be zero sized to represent empty weights. Reviewed By: sryap Differential Revision: D70660808
|
This pull request was exported from Phabricator. Differential Revision: D70660808 |
|
This pull request has been merged in 119879a. |
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Apr 10, 2025
…#853) Summary: Pull Request resolved: facebookresearch/FBGEMM#853 X-link: pytorch#3773 TBE implementation accepts weights to be zero sized to represent empty weights. Reviewed By: sryap Differential Revision: D70660808 fbshipit-source-id: 1e37e4fb9e19efd725a8ce51aae1aa836408255d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: TBE implementation accepts weights to be zero sized to represent empty weights.
Differential Revision: D70660808