Add generic IEEE754 truncation code #3820
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D69941314 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Summary: X-link: facebookresearch/FBGEMM#905 This adds a generic implementation of IEEE754 floatingpoint truncation. This is in preparation for conversion to FP8 E5M2 and FP8 E4M3FN formats but for consistency also replaces the existing float2half conversion functions. Reviewed By: r-barnes Differential Revision: D69941314
MatzeB
force-pushed
the
export-D69941314
branch
from
8340f69 to
e84baf0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69941314 |
|
This pull request has been merged in 49d6314. |
liligwu
pushed a commit
to ROCm/FBGEMM
that referenced
this pull request
Mar 19, 2025
Summary: Pull Request resolved: pytorch#3820 X-link: https://github.com/facebookresearch/FBGEMM/pull/905 This adds a generic implementation of IEEE754 floatingpoint truncation. This is in preparation for conversion to FP8 E5M2 and FP8 E4M3FN formats but for consistency also replaces the existing float2half conversion functions. Reviewed By: r-barnes Differential Revision: D69941314 fbshipit-source-id: 1fb3d34ef3d6bc4613fbc1d522bf7c3eca53d568
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Apr 10, 2025
Summary: X-link: pytorch#3820 Pull Request resolved: facebookresearch/FBGEMM#905 This adds a generic implementation of IEEE754 floatingpoint truncation. This is in preparation for conversion to FP8 E5M2 and FP8 E4M3FN formats but for consistency also replaces the existing float2half conversion functions. Reviewed By: r-barnes Differential Revision: D69941314 fbshipit-source-id: 1fb3d34ef3d6bc4613fbc1d522bf7c3eca53d568
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/905
This adds a generic implementation of IEEE754 floatingpoint truncation.
This is in preparation for conversion to FP8 E5M2 and FP8 E4M3FN formats but for consistency also replaces the existing float2half conversion functions.
Reviewed By: r-barnes
Differential Revision: D69941314