Move DeepGemm scale transpose to quantize #3834
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D71328564 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jwfromm
added a commit
to jwfromm/FBGEMM
that referenced
this pull request
Mar 17, 2025
Summary: X-link: facebookresearch/FBGEMM#920 For more fair comparisons, we can move a bit of scale preprocessing needed by DeepGemm to the quantize step. This diff makes that change and also does a small update to triton to include the latest features. Reviewed By: jiawenliu64 Differential Revision: D71328564
jwfromm
force-pushed
the
export-D71328564
branch
from
3315f9d to
879735c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71328564 |
Summary: X-link: facebookresearch/FBGEMM#920 For more fair comparisons, we can move a bit of scale preprocessing needed by DeepGemm to the quantize step. This diff makes that change and also does a small update to triton to include the latest features. Reviewed By: jiawenliu64 Differential Revision: D71328564
jwfromm
force-pushed
the
export-D71328564
branch
from
879735c to
47aefa0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71328564 |
|
This pull request has been merged in c04ab4e. |
liligwu
pushed a commit
to ROCm/FBGEMM
that referenced
this pull request
Mar 19, 2025
Summary: Pull Request resolved: pytorch#3834 X-link: https://github.com/facebookresearch/FBGEMM/pull/920 For more fair comparisons, we can move a bit of scale preprocessing needed by DeepGemm to the quantize step. This diff makes that change and also does a small update to triton to include the latest features. Reviewed By: jiawenliu64 Differential Revision: D71328564 fbshipit-source-id: bfc54f1856abb72df12f0583add58a328872b5e1
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Apr 10, 2025
Summary: X-link: pytorch#3834 Pull Request resolved: facebookresearch/FBGEMM#920 For more fair comparisons, we can move a bit of scale preprocessing needed by DeepGemm to the quantize step. This diff makes that change and also does a small update to triton to include the latest features. Reviewed By: jiawenliu64 Differential Revision: D71328564 fbshipit-source-id: bfc54f1856abb72df12f0583add58a328872b5e1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: For more fair comparisons, we can move a bit of scale preprocessing needed by DeepGemm to the quantize step. This diff makes that change and also does a small update to triton to include the latest features.
Differential Revision: D71328564