Use bounds_check_indices v2 on ROCm #3916
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No ciflow labels are configured for this repo. |
|
This pull request was exported from Phabricator. Differential Revision: D72334377 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sryap
added a commit
to sryap/FBGEMM
that referenced
this pull request
Apr 2, 2025
Summary: X-link: facebookresearch/FBGEMM#1005 This diff forces using bounds_check_indices v2 on ROCm because ROCm has a constraint that the gridDim * blockDim has to be smaller than 2^32. The v1 kernel can be launched with gridDim * blockDim > 2^32 while the v2 kernel limits the gridDim size to 64 * # of SMs. Thus, its gridDim * blockDim is guaranteed to be smaller than 2^32 Reviewed By: q10, jianyuh, joebos Differential Revision: D72334377
sryap
added a commit
to sryap/FBGEMM
that referenced
this pull request
Apr 2, 2025
Summary: X-link: facebookresearch/FBGEMM#1005 This diff forces using bounds_check_indices v2 on ROCm because ROCm has a constraint that the gridDim * blockDim has to be smaller than 2^32. The v1 kernel can be launched with gridDim * blockDim > 2^32 while the v2 kernel limits the gridDim size to 64 * # of SMs. Thus, its gridDim * blockDim is guaranteed to be smaller than 2^32 Reviewed By: q10, jianyuh, joebos Differential Revision: D72334377
sryap
added a commit
to sryap/FBGEMM
that referenced
this pull request
Apr 2, 2025
Summary: X-link: facebookresearch/FBGEMM#1005 This diff forces using bounds_check_indices v2 on ROCm because ROCm has a constraint that the gridDim * blockDim has to be smaller than 2^32. The v1 kernel can be launched with gridDim * blockDim > 2^32 while the v2 kernel limits the gridDim size to 64 * # of SMs. Thus, its gridDim * blockDim is guaranteed to be smaller than 2^32 Reviewed By: q10, jianyuh, joebos Differential Revision: D72334377
sryap
added a commit
to sryap/FBGEMM
that referenced
this pull request
Apr 3, 2025
Summary: X-link: facebookresearch/FBGEMM#1005 This diff forces using bounds_check_indices v2 on ROCm because ROCm has a constraint that the gridDim * blockDim has to be smaller than 2^32. The v1 kernel can be launched with gridDim * blockDim > 2^32 while the v2 kernel limits the gridDim size to 64 * # of SMs. Thus, its gridDim * blockDim is guaranteed to be smaller than 2^32 Reviewed By: q10, jianyuh, joebos Differential Revision: D72334377
|
This pull request was exported from Phabricator. Differential Revision: D72334377 |
Summary: X-link: facebookresearch/FBGEMM#1005 This diff forces using bounds_check_indices v2 on ROCm because ROCm has a constraint that the gridDim * blockDim has to be smaller than 2^32. The v1 kernel can be launched with gridDim * blockDim > 2^32 while the v2 kernel limits the gridDim size to 64 * # of SMs. Thus, its gridDim * blockDim is guaranteed to be smaller than 2^32 Reviewed By: q10, jianyuh, joebos Differential Revision: D72334377
|
This pull request was exported from Phabricator. Differential Revision: D72334377 |
|
This pull request has been merged in b25dec3. |
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Apr 10, 2025
Summary: Pull Request resolved: facebookresearch/FBGEMM#1005 X-link: pytorch#3916 This diff forces using bounds_check_indices v2 on ROCm because ROCm has a constraint that the gridDim * blockDim has to be smaller than 2^32. The v1 kernel can be launched with gridDim * blockDim > 2^32 while the v2 kernel limits the gridDim size to 64 * # of SMs. Thus, its gridDim * blockDim is guaranteed to be smaller than 2^32 Reviewed By: q10, jianyuh, joebos Differential Revision: D72334377 fbshipit-source-id: 9c955b691e4462721d500b5b643e037d71e13e0c
|
This pull request has been reverted by 00690ec. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff forces using bounds_check_indices v2 on ROCm because ROCm
has a constraint that the gridDim * blockDim has to be smaller than
2^32. The v1 kernel can be launched with gridDim * blockDim > 2^32
while the v2 kernel limits the gridDim size to 64 * # of SMs. Thus,
its gridDim * blockDim is guaranteed to be smaller than 2^32
Differential Revision: D72334377