Skip to content

Fix flaky TBE unit tests #3938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix flaky TBE unit tests #3938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion fbgemm_gpu/test/tbe/bench/tbe_data_config_models_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
PoolingParams,
TBEDataConfig,
)
from hypothesis import given
from hypothesis import given, settings


def rand_int(min_value: int, max_value: int) -> int:
Expand All @@ -30,6 +30,7 @@ class TBEDataConfigModelsTest(unittest.TestCase):
@given(
dtype=st.sampled_from([torch.float32, torch.float64]),
)
@settings(deadline=None)
def test_indices_params_serialization(
self,
dtype: torch.dtype,
Expand Down Expand Up @@ -57,6 +58,7 @@ def test_pooling_params_serialization(self) -> None:
@given(
dtype=st.sampled_from([torch.float32, torch.float64]),
)
@settings(deadline=None)
def test_tbe_data_config_serialization(
self,
dtype: torch.dtype,
Expand Down
7 changes: 3 additions & 4 deletions fbgemm_gpu/test/tbe/training/failures_dict_fast.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
"fbgemm::Fused8BitRowwiseQuantizedToFloat": {},
"fbgemm::asynchronous_complete_cumsum": {},
"fbgemm::bounds_check_indices": {},
"fbgemm::check_feature_gate_key": {},
"fbgemm::dense_embedding_codegen_lookup_function": {
"BackwardDenseTest.test_autograd_registration__test_backward_dense": {
"comment": "",
Expand All @@ -24,6 +25,7 @@
}
},
"fbgemm::emb_inplace_update": {},
"fbgemm::get_infos_metadata": {},
"fbgemm::get_unique_indices": {
"LXUCacheTest.test_faketensor__test_unique_lxu_cache_lookup": {
"comment": "",
Expand Down Expand Up @@ -363,6 +365,7 @@
"fbgemm::split_embedding_codegen_forward_weighted_cuda": {},
"fbgemm::split_embedding_codegen_lookup_adagrad_function": {},
"fbgemm::split_embedding_codegen_lookup_adagrad_function_cpu": {},
"fbgemm::split_embedding_codegen_lookup_adagrad_function_pt2": {},
"fbgemm::split_embedding_codegen_lookup_adam_function": {},
"fbgemm::split_embedding_codegen_lookup_lamb_function": {},
"fbgemm::split_embedding_codegen_lookup_lars_sgd_function": {},
Expand All @@ -381,10 +384,6 @@
},
"fbgemm::split_embedding_codegen_lookup_rowwise_adagrad_function_cpu": {},
"fbgemm::split_embedding_codegen_lookup_rowwise_adagrad_function_pt2": {
"BackwardAdagradTest.test_faketensor__test_backward_adagrad_fp32_cpu": {
"comment": "",
"status": "xfail"
},
"ForwardTest.test_faketensor__test_forward_cpu_fp32": {
"comment": "",
"status": "xfail"
Expand Down
Loading