work around 8-bit imm error in pytorch_bazel_build CI #620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The current code added in D28875981 (pytorch@77a4792) is completely legit, but pytorch_bazel_build CI was giving an error as in https://www.internalfb.com/intern/opensource/ci/job/log/234180188470946/ triggered by D28918331 Differential Revision: D28925945 fbshipit-source-id: e0c7c64d18e48bad02ad12044a601142c69e1dd4
|
This pull request was exported from Phabricator. Differential Revision: D28925945 |
|
This pull request has been merged in b3f1af5. |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 10, 2025
Summary: Pull Request resolved: facebookresearch/FBGEMM#620 Pull Request resolved: facebookresearch/FBGEMM#464 X-link: pytorch#3374 - Add `index_t` support to TBE training backward kernels Reviewed By: basilwong Differential Revision: D65930273 fbshipit-source-id: 076b03a04588d59834786f8069450e777128b2d4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The current code added in D28875981 (77a4792) is completely legit, but pytorch_bazel_build CI was giving an error as in https://www.internalfb.com/intern/opensource/ci/job/log/234180188470946/ triggered by D28918331
Differential Revision: D28925945